Make Nimble SwiftLint compatible #370 #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the project in Carthage with swiftlint installed, there are 11 warnings issued that trip the build. This PR solves all but one by amending the code to correct the offending issues. The last one is fixed by adding a specific disable. This was choosen due to lack of deep knowledge of the finner details of the codebase and the fact that the affected code is underway changes on future PR that are currently WIP.
wongzigii
reviewed
Feb 4, 2017
| @@ -51,7 +51,7 @@ final class BeIdenticalToTest: XCTestCase, XCTestCaseProvider { | |||
| func testBeAlias() { | |||
| let value = NSDate() | |||
| expect(value).to(be(value)) | |||
| expect(NSNumber(value:1)).toNot(be(NSString(stringLiteral: "turtles"))) | |||
| expect(NSNumber(value:1)).toNot(be(NSString(stringLiteral: "turtles"))) // swiftlint:disable:this compiler_protocol_init | |||
There was a problem hiding this comment.
Is this disable rule necessary? Otherwise looks good to me.
|
Hey @lferro9000, There was a merge conflict because of recent CwlPreconditionTesting updates, but I've updated the project to SwiftLint and credited to your name. Also, I've correctly the Here's the commit if you're interested, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the project in Carthage with swiftlint installed, there are 11 warnings issued that trip the build, as reported on the #370 and using the current version available by using Carthage.
This PR solves all but one by amending the code to correct the offending issues.
The last one is fixed by adding a specific disable. This was choosen due to lack of deep knowledge of the finner details of the codebase and the fact that the affected code is underway changes on future PR that are currently WIP.
No behavior of the code was changed.